Repository navigation
ggml-hrx: fence global F32 output before Qwen Q8 packing - #174
Merged
AaronStGeorge merged 4 commits intoNov 3, 2026
Merged
AaronStGeorge merged 4 commits into
AaronStGeorge merged 4 commits into
Conversation
AaronStGeorge
marked this pull request as ready for review
November 3, 2026 19:10
AaronStGeorge
deleted the
users/astgeorg/pr-qwen3-coder-q8-publication
branch
November 3, 2026 19:24
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fence global F32 stores before the fused Qwen MoE normalization kernel reloads them for Q8 packing. Producer and packer workitems own different channel ranges; the existing workgroup-memory barrier does not order their global-memory accesses. This follows the same fix used for decode attention in #154.
The change replaces one barrier memory domain and documents why. It preserves the existing arithmetic and 32-byte LDS allocation.
Validation
On RX 7900 XTX (gfx1100), HRX
82214df, upstream base930e43fe9, flash attention and F16 KV:Requirements